Hi,

-1 binding until license and crypto issues are cleared up.

I notice the NOTICE mentions "Classpath Exception to the GPL” this is Category 
X and can’t be included in an release. See 
http://www.apache.org/legal/resolved.html#category-x

This release also looks to contain crypto software - has this been followed? [4]

I checked:
- file contain incubating
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and  NOTICE have (lots) issues
- source files have headers
- no unexpected binary files
- unable to compile from source (but probably my set up - complains about 
json-c)

License and notice issues:
- LICENSE is missing many BSD, MIT and similar pieces of licensed software. [1] 
For example libpg, PuTTY, pgcrypto, pexpect, gtest + lot of others
- NOTICE should not include MIT, BSD or normally Apache licenses. [1][2]
- NOTICE also should not include anything that is not bundled in the actual 
source release.[3] (e.g. junit)
- Some files listed in NOTICE don’t exist e.g. 
src/google/protobuf/stubs/atomicops_internals_aix.h. This makes it hard to 
review.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
3. http://www.apache.org/dev/licensing-howto.html#guiding-principle
4. http://www.apache.org/dev/crypto.html


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to