Hi, +1 (binding) but only if you raise a JIRA and fix up LICENSE and NOTICE issues for the next release.
Everything here is permissive so it's more a documentation issue than an licensing error. For the next release could you mind mentioning the git/svn hash that the released code corresponds to. I checked: - file contains incubating - DISCLAIMER exists - LICENSE and NOTICE have some issues - NOTICE has incorrect year - All source file had Apace headers (except a couple of shell scripts) - No unexpected binary files - Can compile from source As per [1][2] LICENSE should include: - bootstrap (MIT) - normalize.css (MIT) - datetimepicker (MIT) - fontawesome (MIT) - font awesome fonts (SIL open font licence) - angular (MIT) - JQuery (MIT) - moment.js (MIT) - ng-grid (MIT) - RequireJS (MIT or BSD) - angular-ui-bootstrap (MIT) - jquery.flot (MIT) - raphael (MIT or BSD) - jquery.tablesorter (MIT) - morris.js (BSD) - angular-bootstrap-nav-tree (MIT) I may of missed one or two from a quick glance I took. Basically anything that’s MIT or BSD licensed that's bundled in this source release needs to be added to LICENSE. [2] None of these need to be mentioned in NOTICE. [3] Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle 2. http://www.apache.org/dev/licensing-howto.html#permissive-deps 3. http://www.apache.org/dev/licensing-howto.html#mod-notice --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
