Hi Justin,
// cross posting to dev@brooklyn
Thanks for the detailed review.
Good spot on the other items included in r.js. We had missed those.
All look to be MIT or BSD and so are fine but we do need to call them
out; I will do this.
Your files [2]-[5] are covered as part of distributions of packages we
already credit. I agree we should call out in the LICENSE all files we
include which come from a given distribution; I'll do this also. (These
files are all already listed in [1] so it is an easy addition to have
this info included in the auto-generated LICENSE.)
As for the structure of our LICENSE we wanted it to be it clear from the
start that there are multiple parts to the file. This is because it is
otherwise so easy to overlook embedded licenses; you do a `less` and
assume it's all one license (as we did with r.js). Is our structure
okay given this? Or is there a better way we can accomplish this?
Cheers
Alex
[1]
https://github.com/apache/incubator-brooklyn/blob/master/usage/dist/licensing/overrides.yaml
-------- Forwarded Message --------
Subject: Re: [VOTE] Release Apache Brooklyn 0.8.0-incubating [rc2]
Date: Sat, 12 Sep 2015 09:49:50 +1000
From: Justin Mclean <jus...@classsoftware.com>
Reply-To: general@incubator.apache.org
To: general@incubator.apache.org
Hi,
+1 binding
For the source release I checked:
- release files contain incubating
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE has some issues (see below)
- NOTICE is OK
- No unexpected binary files
- Source files have headers (a few test resources / sample files including java
files don’t however)
Some issues:
- The LICENSE files is structured a little strangely you might want to make it
more like other projects.
- In r.js [2] there a number of copyright owners/licenses (most look to BSD
licenses) that are missing from LICENSE. e.g. uglifyjs, parsejs and base64 code.
- LICENSE is missing sections for dataTables.extensions.js [2],
jquery.slideto.min.js [3], jquery.wiggle.min.js [4] and possible text.js [5].
Thanks,
Justin
1. ./usage/jsgui/src/build/requirejs-maven-plugin/r.js
2. ./usage/jsgui/src/main/webapp/assets/js/libs/dataTables.extensions.js
3.
./apache-brooklyn-0.8.0-incubating-src/usage/jsgui/src/main/webapp/assets/js/libs/jquery.slideto.min.js
4. ./usage/jsgui/src/main/webapp/assets/js/libs/jquery.wiggle.min.js
5. ./usage/jsgui/src/main/webapp/assets/js/libs/text.js
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
This e-mail message is confidential and for use by the addressee only. If
the message is received by anyone other than the addressee, please return
the message to the sender by replying to it and then delete the message
from your computer. Internet e-mails are not necessarily secure. Cloudsoft
Corporation Limited does not accept responsibility for changes made to this
message after it was sent.
Whilst all reasonable care has been taken to avoid the transmission of
viruses, it is the responsibility of the recipient to ensure that the
onward transmission, opening or use of this message and any attachments
will not adversely affect its systems or data. No responsibility is
accepted by Cloudsoft Corporation Limited in this regard and the recipient
should carry out such virus and other checks as it considers appropriate.
