Thanks Justin,
Most issues are relative to website content used for
kylin.incubator.apache.org site which should be excluded from the release
package. Will also check and fix such issue even they not be included in
further release.
The binary file, hbase mini cluster, is included for testing purpose.
The eng_com.dic is generated dictionary file by our code.
Other issue will be fixed soon.
According these, should we re-generate another release candidate and
vote again, or could we go with this RC2 ?
Really would like to learn and know more feedback from community for
our first release.
Thank you very much.
Luke
Best Regards!
---------------------
Luke Han
2015-05-30 10:17 GMT+08:00 Justin Mclean <jus...@classsoftware.com>:
> Hi,
>
> Sorry but it’s -1 binding form me:
> - LICENSE is incorrect and missing 3rd party bundled software
> - Incorrect Apache license headers added to files under other licenses
> - Possible font licensing issues.
>
> Unless that is other IPMC member this it ok to fix these issue in a future
> release and I’ll consider changing my vote.
>
> I checked:
> - incubating in file name
> - DISCLAIMER exists
> - hashes and signatures correct
> - LICENSE and NOTICE issues (see below)
> - All source file have Apache headers
> - One unexpected binary file, but it used for testing
>
> LICENSE is missing information on the bundled versions of font awesome,
> bootstrap, jQuery and normalize.css, See:
> ./kylin-0.7.1-incubating/docs/website/assets/css/font-awesome.min.css
> ./kylin-0.7.1-incubating/docs/website/assets/js/bootstrap.min.js
> ./kylin-0.7.1-incubating/docs/website/assets/js/jquery-1.9.1.min.js
>
> I assuming these were not picked up because the mvn rat target is ignoring
> the docs directory?
>
> See [1] on how to add these permissive licenses to LICENSE.
>
> Looks like there may be some font licensing issues - for instance this
> file:
>
> ./kylin-0.7.1-incubating/docs/website/assets/fonts/helveticaneue-webfont.svg
>
> Which an Apache header has been incorrectly added to(?)
>
> Contains this text:
>
> Created by FontForge 20110222 at Thu Mar 6 12:16:42 2014
> By Orthosie Webhosting
> Copyright (c) 1981, 1982, 1983, 1989 and 1993, Linotype Library GmbH or
> its affiliated Linotype-Hell companies. All rights reserved.
>
> The digitally encoded machine readable software for producing the
> Typefaces licensed to you is now the property of Heidelberger
> Druckmaschinen AG and its licensors, and may not be reproduced, used,
> displayed, modified, disclosed or transferred without the express written
> approval of Heidelberger Druckmaschinen AG.
>
> Copyright (c) 1988, 1990, 1993 Adobe Systems Incorporated. All Rights
> Reserved.
>
> Also this file:
> ./docs/website/assets/css/animate.css
>
> Has had a Apache license added when it is MIT licensed. It’s information
> should also be added into the LICENSE file.
>
> Some other minor issues:
> -There are a few test and doc files without apache header that it could
> probably be added to.
> -There is an archive which also look like it use for testing. Does this
> need to be distributed in the source repo?
>
> ./kylin-0.7.1-incubating/examples/test_case_data/minicluster/hbase-export.tar.gz
> - Can I ask where this file came from and what license was it original
> under?
>
> ./kylin-0.7.1-incubating/dictionary/src/test/resources/dict/eng_com.dic
>
> There are also there two binary font files - who licensing I’m unsure of:
>
> ./kylin-0.7.1-incubating/webapp/app/fonts/ODelI1aHBYDBqgeIAH2zlPytCVloACqnDHJwh-em2k8.woff2
> (may be Source San Pro which is covered by a SIL license so that would
> also need to go into the LICENSE file or be removed)
>
> ./kylin-0.7.1-incubating/webapp/app/fonts/toadOcfmlt9b38dHJxOBGKUt5Ot5NIMarvNW-hkYWvT3rGVtsTkPsbDajuO5ueQw.woff2
> (may be Source Sans Pro Bold?)
>
> Can you also fix:
> - LICENSE is missing the appendix from the standard license [2] can this
> be added.
> - The NOTICE file should have the project name as “Apache Kylin"
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
> 2. http://www.apache.org/licenses/LICENSE-2.0.txt
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
