-0 because of required LGPL dependencies.
(As much as I would prefer LGPL dependencies to be allowed, they are not:
https://www.apache.org/legal/resolved.html )
They are not technically *included* - so legally I think it is
passable for this release, as long as you only distribute this source
release - but it's still not good to have required runtime
dependencies on LGPL as it means anyone distributing binaries of
Apache Ignite will fall under the LGPL license requirements for
Combined Work.
You might want to be careful about putting the binary of
modules/urideploy in Maven - have you checked this with legal@apache?
(IANAL - others on this list might have many other views :) )
BUILD SUCCESS with Oracle JDK 7.
stain@biggie-utopic:/tmp/92/people.apache.org/~dsetrakyan/incubator-ignite-1.0.0/incubator-ignite-1.0.0-src$
mvn -version
Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
2015-03-13T20:10:27+00:00)
Maven home: /home/stain/software/maven
Java version: 1.7.0_72, vendor: Oracle Corporation
Java home: /usr/lib/jvm/jdk1.7.0_72/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-33-generic", arch: "amd64", family: "unix"
What is the license of javafx?
potentially dubious dependency licenses as reported by mvn
license:aggregate-add-third-party:
(GNU LESSER GENERAL PUBLIC LICENSE) c3p0:JDBC
DataSources/Resource Pools (c3p0:c3p0:0.9.1 -
http://c3p0.sourceforge.net)
from modules/core
OK, only <scope>test</scope>
(GNU Lesser General Public License Version 2.1) IRMI
(org.ow2.carol.irmi:irmi:1.1.2 - no url defined)
(GNU Lesser General Public License Version 2.1) Java EE: JTA API
v1.1 (org.ow2.spec.ee:ow2-jta-1.1-spec:1.0-M1 - no
url defined)
from ./modules/jta
OK as it is <scope>test</scope> via jotm-core
BUT:
(LGPL) (Unrestricted) edtFTPj (com.enterprisedt:edtFTPj:1.5.3 -
http://www.enterprisedt.com/products/edtftpj/overview.html)
from modules/urideploy/pom.xml
This one is -1 I am afraid :-(
Perhaps move modules/urideploy to the -Plgpl profile and modify modules/spring?
On 31 March 2015 at 15:29, Dmitriy Setrakyan <dsetrak...@apache.org> wrote:
> On Tue, Mar 31, 2015 at 7:00 AM, Stian Soiland-Reyes <st...@apache.org>
> wrote:
>
>> sorry, my send button was trigger happy..
>>
>> +0 - due to build errors (see below)
>>
>
>> Verified:
>>
>> 1) GPG signature matches BD656948 from KEYS
>> 2) MD5/SHA1 signatures
>> 3) No binaries (except PNGs, test SSL certificates, PDF)
>> 4) DISCLAIMER, LICENSE and NOTICE
>> 5) rat plugin happy (mvn clean validate -Pcheck-licenses)
>>
>> but:
>>
>> 6) FAILS mvn clean package -DskipTests (as DEVNOTES.txt says I
>> should run) -- see below
>>
>
> It should work with Oracle JDK 7, can you try? In the next release JDK will
> not matter, but for now we require Oracle Java 7.
>
>
>> 7) Which git tag is this?
>> https://github.com/apache/incubator-ignite/releases has a lot of RCs..
>> I will assume 'ignite-1.0.0' aka
>> 5fc2cd053467e65872f796e11e3edd2e6017d80d aka
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-ignite.git;a=commit;h=5fc2cd053467e65872f796e11e3edd2e6017d80d
>> -- which matches 100% with the src.zip.
>>
>
> Correct.
>
>
>>
>> 8) It would be good to avoid all those "RC RCs" as it's confusing to
>> have multiple levels of release candidates - in Apache, a Release
>> Candidate is this particular thing you are asking us to vote over.
>> (this might have been pointed out earlier). A pre-release can be
>> called anything else, like alpha, golden master, etc.
>> https://www.apache.org/dev/release.html#what
>>
>>
>>
>> https://repository.apache.org/content/repositories/releases/org/apache/ignite/ignite-core/
>> http://archive.apache.org/dist/incubator/ignite/
>> contains 1.0.0-RC1/ and 1.0.0-RC3/ -- are these released release
>> candidates? Well, done is done, I guess :)
>>
>>
> Agreed. Will not use RCs in the future.
>
>
>>
>> 8) Which of these many open staging Maven repositories is it you are
>> planning to release? Although the voting thread is strictly over
>> source release - it would be nice to know (I think those also should
>> be subject to some checks), and drop the the others.
>> https://repository.apache.org/content/repositories/
>
>
> I think neither. The ones you see are just for testing and will be cleaned
> up.
>
> We are currently experiencing problems with Apache Maven when trying to
> deploy to the repository. I can send another link once the issue is
> resolved.
>
>
>>
>>
>> 9) Due to the build errors I have not checked the dependency licenses,
>> mvn license:aggregate-add-third-party fails with the above error as
>> well.
>>
>
> Again, please rerun with Oracle JDK7. Ideally, devnotes should say
> something about it (will mention this on the website).
>
>
>
>>
>> Build error:
>>
>> [ERROR] COMPILATION ERROR :
>> [INFO] -------------------------------------------------------------
>> [ERROR] /tmp/92/
>> people.apache.org/~dsetrakyan/incubator-ignite-1.0.0/incubator-ignite-1.0.0-src/modules/schema-import/src/main/java/org/apache/ignite/schema/ui/ModalDialog.java:[20,1]
>> package javafx.stage does not exist
>> [ERROR] /tmp/92/
>> people.apache.org/~dsetrakyan/incubator-ignite-1.0.0/incubator-ignite-1.0.0-src/modules/schema-import/src/main/java/org/apache/ignite/schema/ui/ModalDialog.java:[25,43]
>> cannot find symbol
>> symbol: class Stage
>> [ERROR] /tmp/92/
>> people.apache.org/~dsetrakyan/incubator-ignite-1.0.0/incubator-ignite-1.0.0-src/modules/schema-import/src/main/java/org/apache/ignite/schema/ui/ModalDialog.java:[27,21]
>> cannot find symbol
>> symbol: class Stage
>> location: class org.apache.ignite.schema.ui.ModalDialog
>> [ERROR] /tmp/92/
>> people.apache.org/~dsetrakyan/incubator-ignite-1.0.0/incubator-ignite-1.0.0-src/modules/schema-import/src/main/java/org/apache/ignite/schema/ui/ModalDialog.java:[34,27]
>> cannot find symbol
>> symbol: class Stage
>> location: class org.apache.ignite.schema.ui.ModalDialog
>>
>>
>> DEVNOTES.txt does not mention anything special about this. Is this
>> related to javafx?
>>
>>
>> Tested with Maven 3.3.1 on Open JDK 8 on Ubuntu 14.10/x64
>>
>> stain@biggie-utopic:/tmp/92/
>> people.apache.org/~dsetrakyan/incubator-ignite-1.0.0/incubator-ignite-1.0.0-src$
>> mvn -version
>> Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
>> 2015-03-13T20:10:27+00:00)
>> Maven home: /home/stain/software/maven
>> Java version: 1.8.0_40-internal, vendor: Oracle Corporation
>> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "3.16.0-33-generic", arch: "amd64", family:
>> "unix"
>>
>>
>> If I try again with Open JDK 7 instead I get:
>>
>> [ERROR] Failed to execute goal on project ignite-schema-import: Could
>> not resolve dependencies for project
>> org.apache.ignite:ignite-schema-import:jar:1.0.0: The following
>> artifacts could not be resolved:
>> org.apache.ignite:ignite-core:jar:1.0.0, javafx:jfxrt:jar:1.7.0_75:
>> Failure to find org.apache.ignite:ignite-core:jar:1.0.0 in
>> https://repo.maven.apache.org/maven2 was cached in the local
>> repository, resolution will not be reattempted until the update
>> interval of central has elapsed or updates are forced -> [Help 1]
>>
>>
>>
>>
>>
>>
>> On 31 March 2015 at 14:27, Stian Soiland-Reyes <st...@apache.org> wrote:
>> > You did not include the hashes, so I will assume:
>> >
>> > stain@biggie-utopic:/tmp/92/
>> people.apache.org/~dsetrakyan/incubator-ignite-1.0.0$
>> > cat *md5 *sha1
>> > 401e8407bb262aacb1600bb1444488f9 incubator-ignite-1.0.0-src.zip
>> > a8f643ffdc5b45101cf5a9ad5f19b9fce5a4099f incubator-ignite-1.0.0-src.zip
>> >
>> >
>> > I would have expected KEYS to be in the version-independent folder, e.g.
>> >
>> > https://dist.apache.org/repos/dist/release/incubator/ignite/KEYS
>> >
>> >
>> > I would have expected the release candidate to have been uploaded to
>> > ignite/ under
>> > https://dist.apache.org/repos/dist/dev/incubator/
>> > rather than at people.apache.org
>> > (and then just do a svn move of the version folder after approval -
>> > which pretty much guarantees that it's the correct files that were
>> > voted over).
>> >
>> >
>> > Verified:
>> >
>> > 1) GPG signature matches BD656948 from KEYS
>> > 2)
>> >
>> > On 31 March 2015 at 02:38, Dmitriy Setrakyan <dsetrak...@apache.org>
>> wrote:
>> >> Hello,
>> >>
>> >> The Apache Ignite PPMC voted to release Apache Ignite (incubating) 1.0.
>> >>
>> >> We now request the IPMC to vote on the release.
>> >>
>> >> Here is the PPMC voting result form Apache Ignite IPMC (note that 2
>> votes
>> >> are from the IPMC members)
>> >>
>> >> 2 +1 (IPMC)
>> >> 5 +1 (PPMC)
>> >>
>> >> The dev list voting thread:
>> >> http://s.apache.org/N5N
>> >>
>> >> All release artifacts have been uploaded here:
>> >> http://people.apache.org/~dsetrakyan/incubator-ignite-1.0.0/
>> >>
>> >> Please start voting.
>> >>
>> >> +1 - to accept Apache Ignite (incubating) 1.0 release
>> >> 0 - don't care either way
>> >> -1 - DO NOT accept Apache Ignite (incubating) 1.0 release (explain why)
>> >
>> >
>> >
>> > --
>> > Stian Soiland-Reyes
>> > Apache Taverna (incubating), Apache Commons RDF (incubating)
>> > http://orcid.org/0000-0001-9842-9718
>>
>>
>>
>> --
>> Stian Soiland-Reyes
>> Apache Taverna (incubating), Apache Commons RDF (incubating)
>> http://orcid.org/0000-0001-9842-9718
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>>
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
