+1 (binding) John Ament +1 (binding) Dave Johnson +1 (binding) Justin Mclean
The IPMC vote passes. Thanks everybody! - Dave On Sat, Jan 17, 2015 at 6:29 PM, Dave <snoopd...@gmail.com> wrote: > Thanks for the careful review and the +1! > > I filed the issues you raised as USERGRID-358. > https://issues.apache.org/jira/browse/USERGRID-358 > > - Dave > > > > On Sat, Jan 17, 2015 at 6:10 PM, Justin Mclean <jus...@classsoftware.com> > wrote: > >> Hi, >> >> +1 (binding) if LICENSE and NOTICE are fixed up for next release. >> >> - incubating in name >> - DISCLAIMER exists >> - Signatures and MD5 correct (in dist area) >> - LICENSE and NOTICE minor issues (see below) >> - Source files have headers. >> - No unexpected binary files in release >> - Can compile from source >> >> LICENSE issues >> - May require font awesome license (see >> ./docs/_theme/sphinx_rtd_theme/static/css/theme.css) >> - Bootstrap version is MIT not Apache >> ./portal/js/libs/bootstrap/LICENSE.txt >> - Missing MIT license for >> ./sdks/dotnet/packages/Newtonsoft.Json.4.5.11/LICENSE.txt >> - Missing BSD license for NSubstitute >> ./sdks/dotnet/packages/NSubstitute.1.6.0.0/LICENSE.txt >> - Missing BSD license for sphinx eg >> ./docs/_theme/sphinx_rtd_theme/search.html >> >> NOTICE issues >> - Intro.js should be in LICENSE not NOTICE. However i was unable to find >> intro.js anywhere in the package so it may no longer be required >> >> Thanks, >> Justin >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> >
