Hi,

Sorry but it -1 binding due to license and notice issues and there's a jar in 
the source release.

Looks to me that LICENSE and NOTICE still need a little bit of work. As per [1] 
there's no need to add MIT or BSD licensed code to the NOTICE file.

SSToolkit is MIT licensed, Intro.js is MIT licensed and NPM MD5 is BSD licensed 
- these should go into the LICENSE file not the NOTICE file. You might want to 
fix up the misspelling of "product" at the same time.

I also notice an Apache header has been placed on a file that is not Apache 
licensed:
./stack/launcher/src/main/java/org/apache/usergrid/launcher/ClasspathStaticHttpHandler.java

Looks like the same has happen here:
./stack/core/src/main/java/org/apache/usergrid/utils/BCrypt.java

And also here:
./sdks/dotnet/packages/NSubstitute.1.6.0.0/acknowledgements.txt

There may be other instances of this.

The  ClasspathStaticHttpHandler.java file is licensed under GPL (excluded) or 
CDDL (category B) so some care is needed to be taken in including it in source 
form. [2]

There's also a few missing bundled bits missing from LICENSE
- Sphinx Theme (BSD)
- JQuery sparkline (BSD)
- NSubstitute (BSD)
- Moq i(BSD)
- BCrypt (BSD)

The file ./sdks/nodejs/LICENSE states it is MIT licensed is this correct?

You may also want to check these 2 files and there content is different to the 
other LICENSE files in sdks.
./sdks/ruby/LICENSE
./sdks/ruby-on-rails/LICENSE.txt

Several JS files are missing the Apache header and may be licensed under other 
licenses and perhaps also missing from LICENSE. What are the licenses of these 
files?
./portal/js/libs/MD5.min.js (is this the NPM MD5 mentioned in NOTICE?)
./portal/js/libs/jqueryui/jquery.ui.timepicker.min.js (possibly from here? 
http://trentrichardson.com/2010/04/19/timepicker-addon-for-jquery-ui-datepicker/)
./portal/js/libs/jqueryui/date.min.js

There are two version of boostrap, but only one is mentioned in LICENSE:
./portal/js/libs/bootstrap/custom/js/bootstrap.js
./portal/js/libs/bootstrap/custom/js/bootstrap.min.js
./portal/js/libs/bootstrap/js/bootstrap.js
./portal/js/libs/bootstrap/js/bootstrap.min.js

Finally there also a binary jar in the source release:
./sdks/android/m2/repository/org/usergrid/usergrid-java-client/0.0.6/usergrid-java-client-0.0.6.jar

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. http://www.apache.org/legal/resolved.html#category-b
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to