Thanks Justin. The Kokki files (https://github.com/samuel/kokki/tree/master/kokki) did not have any header. We added the Apache License and mentioned Kokki in the top level LICENSE. Let us know if there is an alternate way to handle this situation. We can incorporate it by next release.
-Sumit On Thu, Jul 17, 2014 at 6:18 PM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 binding > > - Vote passed > - incubating in release name > - signatures and hashes correct > - DISCLAIMER exits > - LICENSE and NOTICE good > - No binary files in source release > - all source files have correct headers > - can compile from source > > I did notice one little odd thing and it's probably nothing, but just in > case: > In LICENSE you mention Kokki (BSD license) but all files under > slider-agent/src/main/python/resource_management seem to have Apache > headers. Should any files have BSD headers? > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
