Hi Justin, Thanks for taking time to review. Falcon uses bootstrap Version: v3.0.2 which is Apache License 2.0.
There is a file in the Falcon source release called bootstrap.js which contains the following header: /*! * Bootstrap v3.0.2 by @fat and @mdo * Copyright 2013 Twitter, Inc. * Licensed under http://www.apache.org/licenses/LICENSE-2.0 * * Designed and built with all the love in the world by @mdo and @fat. */ More context at: https://issues.apache.org/jira/browse/FALCON-453?focusedCommentId=14021203&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14021203 Thanks! On Mon, Jul 14, 2014 at 1:08 PM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 (binding) issues with LICENSE > > Looks like source is bundling MIT licensed Bootstrap, MIT licensed D3JS, > MIT licensed dagre and MIT licensed dust, all of those need to be added to > LICENSE. There may be others I've missed. See [1] on how to do this. > > I checked: > - vote thread good > - signature an MD5 hash good > - has DISCLAIMER > - LICENSE mentions subcomponents but contains no licenses and not all > bundles software is Apache licensed > - no binary files in source release > - source headers correct > > I also suggest you look at these for the next release. > - a few files may be missing Apache headers (.twiki and .patch files) > - Is copyright year correct in NOTICE? > - source release contains patch files - are these needed? > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Regards, Venkatesh “Perfection (in design) is achieved not when there is nothing more to add, but rather when there is nothing more to take away.” - Antoine de Saint-Exupéry
