Hi Ankit and other Metamodel developers, Congrats on getting this far with your first release so far. Here's a few questions and concerns:
The NOTICE file should only have what's needed. In your git repo, the last 3 lines I don't think should be there. The NOTICE file in the source jar files look better though. More info on brevity: http://mail-archives.apache.org/mod_mbox/incubator-general/201312.mbox/%3CCAAS6%3D7jc2bHJK_H14bRFEkuDhvfECKw7Qz3%3DaXuMBhQTuWHx1g%40mail.gmail.com%3E However, the NOTICE files in the source jar files do not have "Apache" or "incubating" in the Metamodel name. (If you do re-spin this release you can bump 2013 to 2014 at that point too - I do realize you started this release in 2013, no problem) The *.asc.md5 and *.asc.sha1 files are hashes of PGP signatures and seem unnecessary to me. Not a blocker, but I wouldn't bother creating them for future releases. Less unnecessary files to look at is better. I see your PGP key is at http://www.apache.org/dist/incubator/metamodel/KEYS too. Good. I am not familiar with policies specifically for maven .jar releases. I would think the DISCLAIMER file would still be required. http://incubator.apache.org/guides/release-java.html doesn't mention it, but wouldn't it be appropriate in META-INFO alongside LICENSE and NOTICE? Perhaps someone else can shed some light on this. -Dave On 1/13/14 7:32 AM, Ankit Kumar wrote: > Hi All, > > Please vote on releasing the following candidate as Apache > MetaModel(incubating) version 4.0.0. > This will be the first incubator release for Metamodel in Apache. > > The tag to be voted on is > v4.0.0-incubating:https://git-wip-us.apache.org/repos/asf?p=incubator-metamodel.git;a=tag;h=refs/tags/MetaModel-4.0.0-incubating > > Release artifacts are signed with the following > key:https://people.apache.org/keys/committer/ankitkumar2711.asc > > Release engineer public key id: > B68FA0EF > > > The staging repository for this release can be found > at:https://repository.apache.org/content/repositories/orgapachemetamodel-010/ > > Source jars can be found here: > https://repository.apache.org/content/repositories/orgapachemetamodel-010/org/apache/metamodel/MetaModel/4.0.0-incubating/ > > Result thread link from dev mailing list: > http://mail-archives.apache.org/mod_mbox/metamodel-dev/201401.mbox/%3CCALuGr6aPmPwKgGb5ft%3Dy_BDKPwBKbS7g7QR%2BS6YHAkVg6_nH%2Bg%40mail.gmail.com%3E > > > Please vote on releasing this package as Apache MetaModel 4.0.0-incubating. > > The vote is open until <16th January 2014 14:00 CET> and passes if a > majority of at least 3 IPMC votes are cast. > > Regards > Ankit > -- Dave Brondsema : d...@brondsema.net http://www.brondsema.net : personal http://www.splike.com : programming <>< --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
