On Fri, Dec 30, 2011 at 12:38 PM, Patrick Hunt <ph...@apache.org> wrote:
> -1, I'm afraid there are still licensing issues, the following three > files are not correctly licensed: > > ./bin/flume-env.sh.template > ./conf/log4j.properties > ./flume-ng-core/src/main/avro/flume.avdl > So weird. RAT listed these as AL which is true. I forgot it still says Cloudera. Will fix. > a nit but I'd encourage you to publish the files for a particular > release vote into it's own directory rather than including files from > multiple releases. You can then publish that directory (rather than a > link to particular file(s)) > Will do. Thanks Pat! > > > Otw I don't see any issues, everything else looks fine to me and I > will be +1 once these license headers are corrected. Good job. > > Patrick > > On Fri, Dec 30, 2011 at 12:18 PM, Tom White <t...@cloudera.com> wrote: > > +1 > > > > I verified the signature and MD5 checksum. RAT does not report any > > problems (apart from two generated files and a json file for which > > it's not possible to attach a header). I built and ran unit tests > > successfully. > > > > I noticed a couple of small issues, neither of which is a blocker: > > * It's normal to include a SHA checksum as well as MD5. See > > http://www.apache.org/dev/release-signing.html#reading. Also, the MD5 > > checksum should have an .md5 extension. > > * The URL in the DISCLAIMER file gives a 404: > > http://incubator.apache.org/projects/Flume.html. > > > > Tom > > > > On Thu, Dec 29, 2011 at 8:12 PM, Eric Sammer <esam...@cloudera.com> > wrote: > >> This vote is being called on flume-...@incubator.apache.org and > >> general@incubator.apache.org concurrently. > >> > >> This is the first incubator release for Apache Flume, version > >> 1.0.0-incubating. > >> > >> It fixes the following issues: > >> http://bit.ly/sj5Fh8 > >> > >> *** Please download, test and vote by January 1st, 2012. > >> > >> Note that we are voting upon the source (tag), binaries are provided > >> for convenience. > >> > >> Source files: > >> > http://people.apache.org/~esammer/flume/flume-1.0.0-SNAPSHOT-incubating-rc2.tar.gz > >> > >> The tag to be voted upon: > >> http://svn.apache.org/repos/asf/incubator/flume/tags/flume-1.0.0-rc2/ > >> > >> Flume's KEYS file containing PGP keys we use to sign the release: > >> http://svn.apache.org/repos/asf/incubator/flume/dist/KEYS > >> > >> Note that the Incubator PMC needs to vote upon the release after a > >> successful PPMC vote before any release can be made official. > >> > >> -- > >> Eric Sammer > >> twitter: esammer > >> data: www.cloudera.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Eric Sammer twitter: esammer data: www.cloudera.com
