On 18 August 2011 18:42, Alan Gates <ga...@hortonworks.com> wrote: > Sebastian, > > Thanks for voting. I have a couple questions on your feedback. I didn't > follow what you were saying about having source in the archive and about > having NOTICE etc. files in every archive. HCatalog only has one archive in > this proposed release, hcatalog-0.1.0.tar.gz. This archive does have all the > required files, and it contains the source. You can download this archive > and do a build of the project (which I did before voting). > > Looking through the NOTICE file, it looks like the reference to JDBM is > unneeded, as that is not used. Other than that all the jars referenced in > the file are included in the distribution. So is your concern just the extra > JDBM plus that it says "includes/uses" instead of just "includes"?
Yes, mostly. What about JUnit? The archive includes junit 3.8.1 (seems a bit old - current version is 4.8.2) Also Thrift-Facebook, which has package name com.facebook - suggests it is not part of Apache Thrift Is ANTLR really needed at run-time? Ditto JUnit? If it's only need to build the software it can just be listed as a requirement in the build instructions. Given that the code appears to use Ivy, this should be able to fetch compile-time dependencies automatically. BTW, you include both log4j 1.2.15 and 1.2.16 which looks wrong. Also antlr 2.7.7 and 3.0.1. Mixed jars often cause problems. Not sure you need both commons-logging and commons-logging-api; also latest version is 1.1.1 (released 2007) > Regarding the LICENSE file the licenses for the 3rd party software is in the > Hive's LICENSE file which we include, but we can move it up to the top level > LICENSE file. Yes, all required licenses must be in the top-level LICENSE file. You cannot expect users to hunt around looking for LICENSE files. I would expect to find a separate source release archive, with just the source from the HCatalog project. If I want the source, why should I have to download all the binary dependencies too? BTW, I don't understand why you include an external to Hive source - surely you can just depend on one of the Hive releases? > Alan. > > > On Aug 18, 2011, at 7:25 AM, sebb wrote: > >> On 14 August 2011 23:53, Ashutosh Chauhan <hashut...@apache.org> wrote: >>> Please disregard previous mail due to incorrect subject line. >>> >>> Hi all, >>> >>> HCatalog community is excited to share that RC for first release of >>> HCatalog has been +1'd over at hcatalog-user@incubator Please try it >>> out and vote for the Apache HCatalog 0.1-incubating release. >>> >>> >>> Vote thread: >>> http://markmail.org/thread/5eypr4zl75fmnxuk >>> >>> Artifact and signatures: >>> http://people.apache.org/~hashutosh/hcatalog-0.1.0-incubating-candidate-2/ >> >> The RAT report shows that there are a lot of files without AL headers. >> Some of these are test data comparisons, but it looks as though there >> are a few files that should have headers. >> >>> SVN Tag: >>> https://svn.apache.org/repos/asf/incubator/hcatalog/tags/release-0.1-rc2/ >> >> The NOTICE file format is wrong. The paragraphs are of the form: >> >> This product includes/uses software developed by The Apache Software >> Foundation (http://www.apache.org/). >> >> NOTICE files should only include references to software which is >> actually included in the release. >> i.e. the "/uses" should be removed. >> >> Don't include references to 3rd party software which is not actually shipped. >> >> The NOTICE file is intended for required notices only; it is not a >> dependecy list. >> >> For any 3rd party software that does require an entry in NOTICE, there >> must be a corresponding section in the LICENSE file which contains the >> notice. >> >> These are blockers in my opinion. >> >> Other things to check: >> - N&L and DISCLAIMER files in every archive (and at tag top-level) >> - source archive agrees with SVN tag >> - sigs and hashes work >> >> The ASF is primarily about releasing source; there does not seem to be >> a source archive. >> >> Binary archives are also often provided for convenience, but normally >> these only include the compiled source plus javadoc and perhaps some >> example source. >> >> I think the packaging needs revisiting. >> >>> >>> PGP release keys: >>> https://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.1/KEYS >>> >>> [ ] +1 Release the packages as Apache HCatalog 0.1-incubating >>> [ ] -1 Do not release the packages because... >>> >>> Thanks, >>> Ashutosh >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
