Hi Luciano,
Apologies for the slow review... Things look good, except for one problem, I 
think...

Source, sigs/checksums, and build all look good.

I don't like the licensing information in photark-webapp-M3-incubating.war

First, note how there are redundant license files in WEB-INF/classes/LICENSE 
and WEB-INF/classes/META-INF/LICENSE (I've seen this same problem in another 
project. Can't remember how it was resolved). Also, I don't think the LICENSE 
information (in either file) is accurate. It needs to reflect the licensing 
information for the artifacts contained within the .war. However, I don't think 
it does... 

IMO, this merits a -1...

--kevan

On Nov 28, 2010, at 12:57 PM, Luciano Resende wrote:

> The PhotArk community has completed a vote on it's third milestone
> release (PhotArk M3-Incubating) and  is now looking for IPMC approval
> to publish the release.
> 
> Please review and vote on approving the M3-incubating release
> artifacts of PhotArk.
> 
> The artifacts are available for review at:
> http://people.apache.org/~lresende/photark/M3-incubating-RC1/
> 
> This includes the signed binary and source distributions, the RAT report,
> and the Maven staging repository.
> 
> The release tag is available at :
> http://svn.apache.org/repos/asf/incubator/photark/tags/M3-incubating-RC1/
> 
> The podling vote thread is :
> http://www.mail-archive.com/photark-...@incubator.apache.org/msg01082.html
> 
> -- 
> Luciano Resende
> http://people.apache.org/~lresende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to