Thanks Gavin :-) I addressed all your points in LOG4PHP-90 for a later discussion. Just one +1 necessary - please, if somebody has some time.
On Wed, Dec 9, 2009 at 12:29 PM, Gavin <ga...@16degrees.com.au> wrote: > > >> -----Original Message----- >> From: Christian Grobmeier [mailto:grobme...@gmail.com] >> Sent: Tuesday, 8 December 2009 9:26 PM >> To: general@incubator.apache.org; antel...@apache.org >> Subject: Re: [VOTE] Release RC3 as Log4PHP 2.0.0 >> >> > +1 >> >> Thanks - anybody else who could look into this please? Please help :-) > > Ok, finally got time to review this. > > Some probably minor points: > > 1. There is a logo.jpg in src/site/resources/images - the logo is of Log4J. > I think it was added early on as an example/placeholder until Log4PHP > created there own logo. Not a blocker IMHO but should be removed. > > 2. The top level file called CHANGELOG has some content, then mentions to > refer to a file called changes.xml. I found this file in /src/changes.xml. > It would be nice if the CHANGELOG file pointed to the location of the file. > Not a blocker. > > 3. The DOCS directory included in the distribution is actually the generated > API DOCS - I was expecting to see User Documentation here instead. I would > suggest this directory be renamed API_DOCS or similar. Not a blocker. > > 4. If you are going to the trouble of generating the API DOCS, why not > generate the User Documentation too? This is to be aimed at users as well as > devs and it should be made easy for them. Having them included in the depths > of the source tree as .apt files gives them a harder route and an extra > dependency to build the documentation they seek to use. The documentation is > of course available online. Not a blocker. > > So, the above can be addressed next time I’d say or discussed and > discounted, whatever :) > > +1 to release. > > Gav... > > >> >> > Note that the date in the NOTICE files is 2004-2007. There was a long >> > discussion on the date format on legal-discuss not so long ago and >> > from what i recall this is not a release blocker. >> >> OK i created a task for the next release in jira >> >> > Also there's a bunch of html files in docs\log4php that don't have an >> > Apache License header, it wasn't obvious if they are generated or not >> > but it could be worth seeing if the header can be added to them. >> >> They are all generated. I will also create a jira issue here to check this >> Thanks for your comments! >> Christian >> >> > >> > ...ant >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > For additional commands, e-mail: general-h...@incubator.apache.org >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> No virus found in this incoming message. >> Checked by AVG - www.avg.com >> Version: 9.0.709 / Virus Database: 270.14.87/2536 - Release Date: 12/08/09 >> 05:34:00 > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
