Hey Paul, My vote: -1 (IPMC, binding). Mostly due to some legal tidbits.
I've started looking at this release, but, I *really* don't have the time to look through 100s of artifacts (I imagine much the same is true for the shindig committers?!?), so I can't +1 all these files. It would be a lot easier if there were just a few distributions to look at (1 source, 1 java, 1 php?). The RAT report seems to be broken: http://incubator.apache.org/shindig/shindig-1.1.x/rat-report.html Looking through https://repository.apache.org/content/repositories/shindig-staging-041/org/apache/shindig/shindig/1.1-BETA2-incubating/shindig-1.1-BETA2-incubating-source.tar.gz I've found two big problems: * top-level LICENSE file doesn't contain licenses for all subcomponents shipped in the distro (for example: rhino) * top-level LICENSE file doesn't contain notices for all subcomponents shipped in the distro (for example: zend) That's enough for me to give this release a -1. Please make sure the top-level NOTICE and LICENSE files contain all the notices and license information for everything contained in the distribution archive. https://repository.apache.org/content/repositories/shindig-staging-041/org/apache/shindig/shindig/1.1-BETA2-incubating/shindig-1.1-BETA2-incubating-php.tar.gz has a similar problem -- it ships rhino but the MPL and such are not in the top-level NOTICE/LICENSE files. Please fix. Other more minor nits... https://repository.apache.org/content/repositories/shindig-staging-041/org/apache/shindig/shindig/1.1-BETA2-incubating/shindig-1.1-BETA2-incubating-java.tar.gz the LICENSE file has the boilerplate The Apache Shindig distribution includes a number of subcomponents with separate copyright notices and license terms. Your use of the code for the these subcomponents is subject to the terms and conditions of the following licenses. but then there are no following licenses. Might as well remove that notice. etc/check_staged_release.sh in the source release has no license header. cheers, - Leo On Fri, Sep 4, 2009 at 3:55 PM, Paul Lindner<plind...@linkedin.com> wrote: > Greetings, > The shindig community has voted on and approved a proposal to release > 1.1-BETA2. The next step is approval by the Incubator PMC to publish this > release. The summary is attached below. Note that we did have to respin > the release twice due to issues with checksums. Artifacts are here: > > https://repository.apache.org/content/repositories/shindig-staging-041/ > > and projects reports are here: > > http://incubator.apache.org/shindig/shindig-1.1.x/project-reports.html > > > Please vote to publish this release by Wednesday, Sep 9 12:00 GMT (adding > extra time since the vote spans a weekend and a US holiday). > > [ ] +1 Publish > [ ] +0 > [ ] -0 > [ ] -1 Don't publish, because... > > Much appreciated, > > > ---------- Forwarded message ---------- > From: Paul Lindner <plind...@linkedin.com> > Date: Tue, Aug 4, 2009 at 10:16 AM > Subject: [VOTE] Release Apache Incubator Shindig version 1.1-BETA2 > To: shindig-...@incubator.apache.org > > > Hi, > > I have prepared shindig-1.1-BETA2-incubating release. It includes: > * all of the fixes from the withdrawn 1.1-BETA1 non-release (see below) > * PHP implementations of many 0.9 features > * a fixed java zip file without a war file * Correct checksums. Could > someone else verify? > * Note, sticking with uppercase beta -- if consensus we can switch to lower > case for beta3. > > We solved 16 issues > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310741&styleName=Html&version=12314099 > > Remaining unresolved issues have been moved to 1.1-BETA3 > > Staging repo: > https://repository.apache.org/content/repositories/shindig-staging-041/ > > Web site: > http://incubator.apache.org/shindig/ > > More information about the changes from BETA1 is available here: > > http://mail-archives.apache.org/mod_mbox/incubator-shindig-dev/200907.mbox/< > b71cdca90907231103l6379b3f3ic66cda1cf1c48...@mail.gmail.com> > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > Bug > > - [SHINDIG-609 <https://issues.apache.org/jira/browse/SHINDIG-609>] - fix > oauth url parameters > - [SHINDIG-926 <https://issues.apache.org/jira/browse/SHINDIG-926>] - > XML/ATOM converter failure for appdata REST api > - [SHINDIG-1026 <https://issues.apache.org/jira/browse/SHINDIG-1026>] - > fix signing fetcher warning for empty path > - [SHINDIG-1068 <https://issues.apache.org/jira/browse/SHINDIG-1068>] - > Some tests fail when building with IBM's JVM > - [SHINDIG-1124 <https://issues.apache.org/jira/browse/SHINDIG-1124>] - > Upgrade to caja r3574 > - [SHINDIG-1126 <https://issues.apache.org/jira/browse/SHINDIG-1126>] - > Documentation error > - [SHINDIG-1129 <https://issues.apache.org/jira/browse/SHINDIG-1129>] - > Dynamic height is over-calculated for Webkit-based browsers > - [SHINDIG-1133 <https://issues.apache.org/jira/browse/SHINDIG-1133>] - > NullPointerException in RenderingGadgetRewriter > - [SHINDIG-1134 <https://issues.apache.org/jira/browse/SHINDIG-1134>] - > JsonProperty Annotations not working properly for both > marshalling/unmarshalling > > Improvement > > - [SHINDIG-678 <https://issues.apache.org/jira/browse/SHINDIG-678>] - > Autoloader chain > - [SHINDIG-822 <https://issues.apache.org/jira/browse/SHINDIG-822>] - > Remove caja's dependence on opensocial feature > - [SHINDIG-855 <https://issues.apache.org/jira/browse/SHINDIG-855>] - > Enum value should be checked if it is empty > - [SHINDIG-856 <https://issues.apache.org/jira/browse/SHINDIG-856>] - > Defaults to cont...@type="html" when omitted > - [SHINDIG-857 <https://issues.apache.org/jira/browse/SHINDIG-857>] - > public key id param key should be xoauth_public_key > - [SHINDIG-1107 <https://issues.apache.org/jira/browse/SHINDIG-1107>] - > Clean up shindig dependencies > - [SHINDIG-1135 <https://issues.apache.org/jira/browse/SHINDIG-1135>] - > Bump ehcache to 1.6.1 > -- cheers, Leo Simons -- http://lsimons.wordpress.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
