Overall looks fine to me but one question: at least in Axis2 releases we
include the licenses for all the dependent stuff- for example for the
backport-concurrent stuff. If you take a look at the axis2 distro you'll
see a .license file for every external dependency in the lib/ directory.
If that's not a problem for this then I'm +1 for this release. Maybe one
of the more legally inclined incubator PMC folks can ack/nack that condition?
Sanjiva.
Matthieu Riou wrote:
I've posted a new RC addressing all the issues you've mentioned. The only
gotcha is with the SQL files, these come from Quartz (Open Symphony
project,
Apache 2.0 license). So for these I've just added a short note pointing to
the NOTICE, which mentions the license and copyright. Hope this is enough.
Otherwise, all missing headers have been added.
The new release, 1.0-RC4, can be found here:
- The WAR-based distribution
http://people.apache.org/~mriou/ode-1.0-RC4/org/apache/ode/apache-ode-war/1.0-RC4-incubating/
- The JBI-based distribution
http://people.apache.org/~mriou/ode-1.0-RC4/org/apache/ode/apache-ode-jbi/1.0-RC4-incubating/
- The source distribution
http://people.apache.org/~mriou/ode-1.0-RC4/org/apache/ode/apache-ode-sources/1.0-RC4-incubating/
Thanks a lot for your time checking our release!
Matthieu
On 5/17/07, robert burrell donkin <[EMAIL PROTECTED]> wrote:
On 5/15/07, Matthieu Riou <[EMAIL PROTECTED]> wrote:
> The ODE community held a vote for its first incubator release. See [1]
for
> the tally of 6 +1s (including one mentor vote) and no 0 or -1s. We're
now
> asking for a vote by the incubator PMC to authorize the publication of
our
> 1.0 release.
>
> The release consists of 3 different artifacts:
>
> - A WAR-based distribution [2]
> - A JBI-based distribution [3]
> - A source distribution [4]
>
> Please cast your votes:
>
> [ ] +1 release is approved
> [ ] -1 veto the release (provide specific comments)
not sure ATM
BTW i'm offline next week so hopefully other folks will be able to pick
stuff up
Issues
=====
RAT:
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/assemble_jdoc.rb
looks to be a creative work in a format supporting comments. if so
then it should have the standard header
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/bpel-api/src/main/java/org/apache/ode/bpel/iapi/TwoWayUnreliable.usd
again looks to be in format capable of supporting comments. is it
generated? (if not, then it should have a header)
ditto
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/bpel-api/src/main/java/org/apache/ode/bpel/iapi/TwoWayReliable.usd
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/bpel-api/src/main/java/org/apache/ode/bpel/iapi/TwoWayWithTransactionPropagation.usd
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/bpel-api/src/main/java/org/apache/ode/bpel/iapi/TwoWayIdempotent.usd
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/bpel-test/src/test/resources/bpel/2.0/TestXslTransform/HelloXslWorld.xsl
looks borderline creative to me and looks to be a format capable of
supporting comments. if so (and it isn't generated) then it should
probably have a header
the follow also worry me (for similar reasons):
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-hibernate-db/src/main/sql/tables_derby.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-hibernate-db/src/main/sql/tables_firebird.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-hibernate-db/src/main/sql/tables_hsql.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-hibernate-db/src/main/sql/tables_mysql_innodb.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-hibernate-db/src/main/sql/tables_oracle.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-hibernate-db/src/main/sql/tables_postgres.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-hibernate-db/src/main/sql/tables_sqlserver.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-jpa-ojpa-derby/src/main/scripts/quartz-derby.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-jpa-ojpa-derby/src/main/scripts/quartz-firebird.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-jpa-ojpa-derby/src/main/scripts/quartz-innodb.sql
http://svn.apache.org/repos/asf/incubator/ode/tags/APACHE_ODE_1.0-RC3-INCUBATING/dao-jpa-ojpa-derby/src/main/scripts/quartz-sqlserver.sql
comments and suggestions (not normative)
===================================
release notes look good. the same content can be used as the basis for
announcement posts and for download pages.
--
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]