On 29 April 2018 at 06:50, Henk P. Penning <[email protected]> wrote: > On Sat, 28 Apr 2018, sebb wrote: > >> Date: Sat, 28 Apr 2018 23:00:32 +0200 >> From: sebb <[email protected]> >> To: [email protected] >> Subject: Proposed httpd tlp config changes for Attic redirects >> >> I've created an updated copy of the TLP httpd configs for the proposed >> flags/banners layout: >> >> >> https://github.com/apache/infrastructure-puppet/compare/deployment...sebbASF:attic-flags >> >> The rules are in addition to the existing rules. >> This makes it easier to do a changeover. >> Once the new layout is in place, the old rules can be dropped. >> >> @henkp: do the rules look OK to you? > > > 'banners' is a file ; so, use '-f' instead of '-d' : > > - <If "-d '/var/www/attic.apache.org/flags/%%{}{HTTP_HOST}/banners'"> > + <If "-f '/var/www/attic.apache.org/flags/%%{}{HTTP_HOST}/banners'">
Good catch. Fixed. >> If so, I can create a pull request. > > > I think we should stop 'fixing' the 'old' site and move > to a new site. The HTTPD changes have to be in place *before* any move. Also it makes sense to test the changes before a move. So I think the sequence should be: Update TLP httpd configs. This should not affect existing behaviour as the rules are additional. Test at least one banner and one dist redirect. The dist redirect test should be easy as already noted. If the banner prefixing works with a non-existent site (404) then that will be easy to test as well. >> I think it would make sense to implement the rules on the existing >> site initially. >> >> This can be done by copying the generated directories/files from the >> jekyll or lua PoCs >> [This is a one-off, so no need to automate it] >> >> It would be easy to test the dist/ redirection by creating a dummy >> flags directory. >> >> I think it requires an existing site to test the banners. > > > HPP > > ------------------------------------------------------------ _ > Henk P. Penning, ICT-beta R Uithof MG-403 _/ \_ > Faculty of Science, Utrecht University T +31 30 253 4106 / \_/ \ > Leuvenlaan 4, 3584CE Utrecht, NL F +31 30 253 4553 \_/ \_/ > http://www.staff.science.uu.nl/~penni101/ M [email protected] \_/
