On 2022-03-09 4:02 p.m., Even Rouault wrote:

Le 09/03/2022 à 20:53, Jeff McKenna a écrit :
Thanks Even.  RC2 works well on Windows in the MS4W build environment. The only issue was that I had to re-apply the patch for Poppler 22.x (this is the known issue of course, that is well discussed https://lists.osgeo.org/pipermail/gdal-dev/2022-March/055529.html )

Which patch did you need re-apply ? The ones of master are normally included in 3.4.2 : https://github.com/OSGeo/gdal/commit/2d5f96f233e6bda613e98e056bb9a39d12409e32 + https://github.com/OSGeo/gdal/commit/cbcfe2c8c5507ea00ef7371029ff94d0bf6f4a77 .  But for nmake based builds, you perhaps need to add a /std:c++17 switch to the POPPLER_CFLAGS variable (PS: the benefit of the CMake based builds where a single CMake command can be used to bump to c++17 for all platforms is obvious here)

My builds are CMake, and that was the exact patch I've been applying to the POPPLER_EXTRAFLAGS, you're correct. After that, CMake runs fine for me.

-jeff




--
Jeff McKenna
GatewayGeo: Developers of MS4W, MapServer Consulting and Training
co-founder of FOSS4G
http://gatewaygeo.com/
_______________________________________________
gdal-dev mailing list
gdal-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/gdal-dev

Reply via email to