On 5/14/21 3:41 AM, Jakub Jelinek wrote:
On Thu, May 13, 2021 at 08:56:39PM -0400, Jason Merrill wrote:
>From 8718fbbf83978bd8ec4bf0a0e4164459158df182 Mon Sep 17 00:00:00 2001
From: Jason Merrill <ja...@redhat.com>
Date: Thu, 13 May 2021 20:53:50 -0400
Subject: [PATCH] intl: add comments to _, N_, and G_
To: gcc-patc...@gcc.gnu.org

gcc/ChangeLog:

        * intl.h: Add comments.
---
  gcc/intl.h | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/gcc/intl.h b/gcc/intl.h
index 829364ae905..f21ec11ada0 100644
--- a/gcc/intl.h
+++ b/gcc/intl.h
@@ -47,14 +47,19 @@ extern const char *fake_ngettext (const char *singular, 
const char *plural,
#endif +/* Used to immediately translate the argument. */
  #ifndef _
  # define _(msgid) gettext (msgid)
  #endif
+/* Used to mark strings that will be translated later. */
  #ifndef N_
  # define N_(msgid) msgid
  #endif
+/* Like N_, but used for diagnostic strings, to tell gettext that this is a
+   gcc-internal-format string rather than standard c-format.  exgettext gets
+   this from the 'g' in "gmsgid", which is also used in diagnostic.c.  */
  #ifndef G_
  # define G_(gmsgid) gmsgid
  #endif

I'd just write
/* Like N_, but for GCC diagnostic format strings.  See ABOUT-GCC-NLS for
    details.  */

Aha, that's where the documentation lives!  Committed with that change.

Jason

Reply via email to