On Tue, 16 Jun 2020 at 10:11, Martin Jambor <mjam...@suse.cz> wrote: > > Hi, > > On Mon, Jun 15 2020, Segher Boessenkool wrote: > > Hi! > > > [...] > > What. > > > > Of course it is not a fast-forward. I rebase the branches I publish, > > what is the point of publishing them otherwise? This is so that people > > can see the stuff that will make its way into master *later*. > > > > The number of new commits is nonsense (it is just 13), and the number of > > emails that triggers should be 0. > > > > Please fix? Or, what else is wrong? > > while I tend to agree that sending emails about commits to user branches > is not a good idea, I also believe that you should (almost?) never > rebase a public branch. Certainly not if you expect anyone else to > fetch it or - god forbid - base some of their commits on it, as opposed > to just reading it through the web interface. I'd suggest appending a > date to the namer of the branch and thus always publish a new branch, > making it clear that its history is different.
I see no harm in rebasing public branches as long as nobody expects otherwise. A public branch on gcc.gnu.org under refs/heads that is being pulled by unknown persons and used in unknown forks for unknown purposes shouldn't be rebased, because you don't know who you're causing problems for by doing so. But a personal branch like Segher's could disappear at any time. If we're going to discourage rebasing, we should also discourage deleting personal branches. But I don't see any benefit to that. If I create a branch refs/users/redi/work-in-progress for somebody else to look at and then delete it, do I have to remember never to create another branch using that name in future, in case somebody pulled the old branch before I deleted it? Randos on the internet aren't going to be basing work on those branches accidentally, they're not fetched by default so you have to make some non-trivial effort to even fetch them. If you do that, you should know you're not using an official GCC branch, but one that Segher can rebase or completely delete at any time. I think only the owner of a personal branch should decide what workflow and rebasing policies apply to that branch.
