On 5/26/20 12:15 PM, Pierre-Marie de Rodat wrote:
Hello Martin,
First, thank you for your work on this new ChangeLog workflow. :-)
Hello.
Thank you.
I’d like to report a “regression”: I can’t push the attached patch:
remote: *** ChangeLog format failed:
remote: ERR: changed file not mentioned in a ChangeLog:"gcc/ada/sem_ch4.adb"
remote: ERR: changed file not mentioned in a ChangeLog:"gcc/ada/sem_ch7.adb"
remote: ERR: changed file not mentioned in a ChangeLog:"gcc/ada/sem_ch8.adb"
remote: ERR: changed file not mentioned in a ChangeLog:"gcc/ada/sem_elab.adb"
remote: ERR: changed file not mentioned in a ChangeLog:"gcc/ada/sem_type.adb"
remote: ERR: changed file not mentioned in a ChangeLog:"gcc/ada/sem_util.adb"
remote: remote: Please see:
https://gcc.gnu.org/codingconventions.html#ChangeLogs
remote: remote: error: hook declined to update refs/heads/master
It looks like the hook does not accept multi-line ChangeLog entries affecting
multiple files:
* contracts.adb, einfo.adb, exp_ch9.adb, sem_ch12.adb,
sem_ch4.adb, sem_ch7.adb, sem_ch8.adb, sem_elab.adb,
sem_type.adb, sem_util.adb: Reuse Is_Package_Or_Generic_Package
where possible (similarly, reuse Is_Concurrent_Type if it was
possible in the same expressions).
Would it be possible to enhance the hook to support that?
It's not supported right now and it will make the filename parsing much more
complicated.
I would recommend using ./contrib/mklog and using:
* a.adb: Foo bar.
* b.adb: Likewise.
...
Thanks,
Martin
Thanks!
