On Thu, Nov 05, 2015 at 10:32:11AM +0100, Bernd Schmidt wrote:
> When reviewing patches I'm never quite sure which of the following we should
> be using:
>
> some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED)
>
> some_target_hook (tree decl, machine_mode ARG_UNUSED (mode))
>
> some_target_hook (tree decl, machine_mode /* mode */)
>
> some_target_hook (tree decl, machine_mode)
>
> Any opinions? I'm leaning towards the last version since it's idiomatic in
> the language we're using and has the least amount of visual clutter. If no
> one comments, I'll start enforcing that in patch reviews. Currently no one
> seems sure and everything is getting totally inconsistent.
FWIW, I also like the last version best.
Marek
