On 20/03/15 16:02, Claudiu Zissulescu wrote:
Hi Joern,
I have a small patch for ARC backend that fixes the value of instruction length
attribute when the instruction is predicated. Ok to apply?
Why would the arc_bdr_iscond test have any effect?
arc_predicate_delay_insns should render the issue moot.
Moreover,
- your patch has no ChangeLog entry.
+extern bool arc_bdr_iscond (rtx);
- New code should use const rtx_insn * .
+ conditionally. */
- ^ The GNU coding standard requires two spaces here.
- (const_int 2))
+ (match_test "GET_CODE (PATTERN (insn)) == COND_EXEC || arc_bdr_iscond
(insn)")
+ (const_int 4)]
+ (const_int 2))
- You are mis-formatting the code. (const_int 2) is part of the cond clause.
