> -----Original Message----- > From: Gerald Pfeifer [mailto:ger...@pfeifer.com] > Sent: Wednesday, October 30, 2013 9:39 PM > To: Iyer, Balaji V > Cc: Jeff Law; gcc@gcc.gnu.org > Subject: libcilkrts/runtime/config/generic/cilk-abi-vla.c failure (was: > [PATCH, > committed] libcilkrts - Add check for availability of alloca.h (Bug > Bootstrap/58918)) > > On Wed, 30 Oct 2013, Iyer, Balaji V wrote: > > This attached patch will check for usage of alloca.h before using it. > > The change is entirely in libcilkrts and I am committing this change > > as it is pretty obvious (the change was lifted from the autconf manual > > example). > > Thanks, Balaji! > > Now my FreeBSD tester no longer shows this failure, but this: > > /scratch2/tmp/gerald/gcc-HEAD/libcilkrts/runtime/config/generic/cilk-abi-vla.c: > In function \xe2\x80\x98__cilkrts_stack_free\xe2\x80\x99: > /scratch2/tmp/gerald/gcc-HEAD/libcilkrts/runtime/config/generic/cilk-abi- > vla.c:1 > 06:28: error: \xe2\x80\x98t\xe2\x80\x99 undeclared (first use in this > function) > vla_internal_heap_free(t, full_size); > ^ > > Looking at the source coude, indeed t is not declared anywhere that I can see. > > So, two issues: > > - Why is it using the /generic subdirectory and not /x86 on > i386-unknown-freebsd10.0? >
It is because of this line: i[456]86-*-*) config_dir="x86" ;; It should include a 3 too. My bad sorry. I have fixed it. Attached, please find a patch. It is committed as obvious. > - What doesn't libcilkrts/runtime/config/generic/cilk-abi-vla.c compile? > I will ask my team and get back to you. > Gerald
Index: libcilkrts/configure =================================================================== --- libcilkrts/configure (revision 204244) +++ libcilkrts/configure (working copy) @@ -4907,7 +4907,7 @@ config_dir="x86" ;; - i45686-*-*) + i?86-*-*) config_dir="x86" ;; Index: libcilkrts/configure.ac =================================================================== --- libcilkrts/configure.ac (revision 204244) +++ libcilkrts/configure.ac (working copy) @@ -115,7 +115,7 @@ config_dir="x86" ;; - i[456]86-*-*) + i?86-*-*) config_dir="x86" ;; Index: libcilkrts/ChangeLog =================================================================== --- libcilkrts/ChangeLog (revision 204244) +++ libcilkrts/ChangeLog (working copy) @@ -1,5 +1,9 @@ 2013-10-30 Balaji V. Iyer <balaji.v.i...@intel.com> + * configure.ac: Changed a case statement to include i386. + +2013-10-30 Balaji V. Iyer <balaji.v.i...@intel.com> + * configure: Reconfigured. * configure.ac: Add AC_FUNC_ALLOCA. * runtime/sysdep-unix.c: Added check for alloca.h before