Hi,

On Fri, Oct 18, 2013 at 10:00:13AM -0400, Andrew MacLeod wrote:
> At a minimum, I do think that if a .h file *requires* another .h
> file to compile, that it should include it.

Absolutely.

>  ie, if gimple-ssa.h is
> included, it wont compile unless tree-ssa-operands.h has already
> been included, so that seems reasonable to include directly in
> gimple-ssa.h.  Otherwise ones needs to add the file,  compile, and
> then figure out what other file you need.  That seems silly to me.

Indeed.  And it is easy to overlook the file is already included
couple of lines below.  This has just happened to me when dealing with
all requirements for the new tree-phinodes.h.

Thanks,

Martin

Reply via email to