Hi,

On Thu, 21 Feb 2013, Richard Biener wrote:

> Do people think that the fine-grained verification control
> is actually useful or do you agree with me that it leads to
> sloppiness?

I agree with you ...

> --- 1955,1982 ----
>       return;
>   
>   #if defined ENABLE_CHECKING
> !   if (flags & TODO_verify_il)
>       {
> !       if (cfun->curr_properties & PROP_cfg)
> !     verify_flow_info ();
> !       if (cfun->curr_properties & PROP_loops)
> !     verify_loop_structure ();
> !       if (cfun->curr_properties & PROP_gimple_any)
> !     {
> !       if (cfun->curr_properties & PROP_cfg)
> !         verify_gimple_in_cfg (cfun);
> !       else
> !         verify_gimple_in_seq (gimple_body (cfun->decl));
> !     }
> !       if (cfun->curr_properties & PROP_ssa)
> !     {
> !       verify_ssa ();
> !       if (current_loops && loops_state_satisfies_p (LOOP_CLOSED_SSA))
> !         verify_loop_closed_ssa (false);
> !     }
> !       if (cfun->curr_properties & PROP_rtl)
> !     verify_rtl_sharing ();

... but I think the checking should be bottom up.  First test gimple, 
then the cfg, then ssa, then loops, then loop-closedness.


Ciao,
Michael.

Reply via email to