> Indeed.  I also wonder why dump_kind_p does not check if dumping is
> active at all?  Thus, inside check dump_file / alternate dump_file for NULL.

I am testing a patch which includes a check for
dump_file/alternate_dump_file in dump_kind_p. This is in addition to
checking flags.

>> 2. dump_kind_p seems to always return 0 if current_function_decl is
>>    NULL.  However, that precludes its use in IPA passes in which this
>>    can happen regularly.  Why is this restriction necessary?
>
> Arguably a bug.  Not sure why it was done this way.

Yes, it is a bug. I am fixing this as well.

Thanks,
Sharad

Reply via email to