Joel,

>> That's what my patch does.  It would be good if Joel could test on
>> i386-rtems before comitting (as I will on Solaris/SPARC and x86, of
>> course).
>>
> i386-rtems builds fine after moving the files.
>
> From my perspective, you can commit.

Thanks for the confirmation.  I've run i386-pc-solaris2.{8, 11} and
sparc-sun-solaris2.{8, 11} bootstraps overnight.  Solaris 8 builds
crt[in].o, while they are included on Solaris 11 and thus skipped in
libgcc.  They completed without regressions (with the exception of
Solaris 8/SPARC where jc1 ICEs at one point, but that's unrelated).

I've now committed the patch.

>>>> The rules are generic and have been integrated into libgcc/Makefile.in,
>>>> but only used unless CUSTOM_CRTIN is set in a target fragment.
>>> s/unless/if/ I presume?  config/t-sol2 has the rules though so 
>>> config/t-rtems
>> No, if a t-* fragment sets CUSTOM_CRTIN, it's expected to provide its
>> own crt[in].o rules, just like the existing CUSTOM_CRTSTUFF does.  If
>> crt[in].o is not included in extra_parts, the generic rules are
>> unused/harmless.
>>
>>> could just copy them, at least for now.
>> True, but that's the sort of copy-and-paste programming I'd like to
>> reduce with this series of patches.
>>
> Thank you.  Avoiding cut and paste makes it easier
> for targets like RTEMS where we really do try to rely
> as much as possible on sharing. :)

Right, and it's less likely to miss new features...

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to