On Fri, Sep 23, 2011 at 6:42 PM, Bingfeng Mei <b...@broadcom.com> wrote: > Hi, > I notice the following description is different from how spu & m32c use it. > > In internal manual: > > bool TARGET_ADDR_SPACE_SUBSET_P (addr space t superset, [Target Hook] > addr space t subset) > Define this to return whether the subset named address space is contained > within the > superset named address space. Pointers to a named address space that is a > subset > of another named address space will be converted automatically without a cast > if > used together in arithmetic operations. Pointers to a superset address space > can be > converted to pointers to a subset address space via explicit casts. > > In spu & m32c ports: > m32c_addr_space_subset_p (addr_space_t subset, addr_space_t superset) > spu_addr_space_subset_p (addr_space_t subset, addr_space_t superset) > > I believe the document is wrong. The first argument is subset and the second > one is superset. Should I submit a patch?
Sure. > Cheers, > Bingfeng Mei > >
