Quoting Richard Guenther <richard.guent...@gmail.com>:
Btw, I think these partial conversions are not appropriate for stage3 and if accepted for stage1 you should commit yourself to do a transition that at least allows converting targets (thus, I don't like your incremental patches at all).
I don't understand what makes you say this. Partial conversions have much lower chance of breaking things when the macro is set up in complicated ways, and you also trivially avoid performance regressions at non-converted call site. At the same time, frontends show a lot of instability because of the way they interact with target macros, and this can be eliminated with a partial conversion to target hook. For example for PR46738, I think it is best to change the two current users of ASM_OUTPUT_IDENT - c-family/c-lex.c and ada/gcc-interface/trans.c to use a hook, and define the hook in targhooks.c in terms of ASM_OUTPUT_IDENT, but leave it for stage1 to sort out the mess of #defines #ifdefs / #undefs that govern the definition of this macro.
