On 22 June 2010 08:28, Ian Lance Taylor <i...@google.com> wrote: > Basile Starynkevitch <bas...@starynkevitch.net> writes: > >> What are exactly GCC code types, defined in gcc/coretypes.h? > > They are types for which there was no obvious place to put them. > >> Of course, they are very important types used in GCC. And there are >> probably wired in gengtype (but maybe not all of them; I didn't check >> for all; certainly gengtype handle tree & gimple specially in some >> way.). > > gengtype only handles a few types specially. There is no particular > connection between types recognized by gengtype and coretypes.h. > E.g., gengtype handles VEC specially, but it is not in coretypes.h. > >> However, I don't understand why gimple_seq_node is a core type. It seems >> rarely used (outside of gimple*.[ch] files), and I would imagine it >> could be kept in gimple.h. > > I agree. I expect it's there just because gimple_seq is there. >
Basile, if you can move it to gimple.h and bootstrap + regression test, then I am pretty sure such a patch would be accepted. If moving it breaks something, then probably there is a reason for it to be there and if it is not easy to fix it, at least, you can add a comment. Manuel.
