l...@dm.botik.ru (Alexey I. Adamovich) writes: > Forgot RID_LAST_MODIFIER > > On Sat, Aug 29, 2009 at 08:29:21PM +0400, Alexei I. Adamovich wrote: >> So for the sake of those who will develop C-derived front ends, should >> we change the comment like below: >> > /* Reserved identifiers. This is the union of all the keywords for C, >> > C++, and Objective-C. In the past, in earlier GCC versions all the >> > type modifiers had to be in one block at the beginning, because >> > they were used as mask bits. There were 27 type modifiers; so if >> > anybody added many more the mask mechanism would have to be >> > redesigned. Now it doesn't matter, since corresponding mask >> > machinery gone */ > > Should the last lines be re-written as follows: >> redesigned. Now it doesn't matter, since corresponding mask >> machinery gone. But anyway when adding any type modifier it's >> better to follow the old rule and to get sure that >> RID_LAST_MODIFIER is defined and handled correctly also */ > [?]
I think we should drop the reference to previous gcc versions and the old scheme. I don't think it helps in understanding the code. It's still necessary to set RID_LAST_MODIFIER correctly as declspecs_add_type uses it. Ian
