Hello All

in gcc/plugin.c of trunk rev148566 function add_new_plguin line 147, I am reading

 /* If the same plugin (name) has been specified earlier, either emit an
    error or a warning message depending on if they have identical full
    (path) names.  */
 if (*slot)
   {
     plugin = (struct plugin_name_args *) *slot;
     if (strcmp (plugin->full_name, plugin_name))
       error ("Plugin %s was specified with different paths:\n%s\n%s",
              plugin->base_name, plugin->full_name, plugin_name);
     return;
   }

Does the comment still apply? I am understanding we always issue an error, and never warnings in that case...

Maybe the comment could be
/* if the same plugin name has been specified earlier, issue an error message if the path are different */

But perhaps there is some trick elsewhere. If it is the case, I would suggest the comment should cite the function doing the trick.


Regards.

PS. I hope that questions on code belong to gcc@, not gcc-patches@ - I am not discussing a patch or proposing one ...

--
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***

Reply via email to