On 06/06/07, Brian Sidebotham <[EMAIL PROTECTED]> wrote:
Hi,
I am building a cross-compiler for arm, which builds "okay", but the
output is very noisy whilst compiling gcc. I'd like to sort some of it
out and submit some patches, but I've not done any patches for gcc
before so I don't want to create a lot of noise on the gcc-patches list
by posting up patches that are not considered correctly formatted, etc.
The problem is not the noise, the problem is taking time from people.
The time required to discuss your patch is the same here or in
gcc-patches.
So if you want to send a good patch:
1) Read http://gcc.gnu.org/contribute.html
2) Look up examples in gcc-patches http://gcc.gnu.org/ml/gcc-patches/
At the end of this message is a patch to remove a 'variable might be
used uninitialised' warning which is thrown up whilst bootstrapping gcc.
Be more explicit, which line or which variable produces the warning?
Is this patch okay to submit to the gcc-patches list?
Sorry, it is not. Apart from other things (like changes that only
affect to whitespace), your patch must bootstrap and pass the
regression testsuite. I have a hunch that the patch below does not
bootstrap.
I haven't touched the ChangeLog, should I fill it in?
You don't need to fill the Changelog file up to the moment when you
commit (it is not recommend since it will provoke conflicts when
applying the patch). But you need to post the text that you are going
to include in the Changelog. Again, look at
http://gcc.gnu.org/ml/gcc-patches/ for examples.
Let us know if you have any other doubts. It is always hard to get it
right the first time.
Cheers,
Manuel.
