On Thu, 2006-02-16 at 11:59, Denis Nagorny wrote: > It's corrected and tested on ia64 and x86-64. I've attached new version. > Denis.
This look pretty good. There is still one place where the spacing looks funny. > + if (test >= regno && test < endregno) > + return 1; Checking this in emacs, I see that the if statement is preceded by 8 spaces, and the return is preceded by a tab and 8 spaces. It should be only a tab before the if, and a tab and 2 spaces before the return. Do you have tab stops set every 8 characters? It looks like you might have tabs set to 2 characters, otherwise I don't see how you could make this mistake and not notice it. There are also 3 other lines that start with spaces that should start with tabs, though this is only a minor problem. Andrew Pinksi made a good suggestion. The AUTO_INC_DEC ifdefs should be placed around the reg_inc_found_and_valid_p function instead of inside it. This lets you get rid of the ATTRIBUTE_UNUSED stuff, and it also is more efficient, since it saves the cost of a call for !AUTO_INC_DEC targets. -- Jim Wilson, GNU Tools Support, http://www.specifix.com
