On Fri, 2005-04-01 at 00:38, Nathan Sidwell wrote:
> Here it is, ok?
The patch is OK. The ChangeLog entry should refer to INTEGER_CST
instead of INT_CST.
You are missing a ChangeLog entry for the testcase.
The testcase is not portable, as I pointed out in the PR. Trying this
on an x86_64-linux system, I get 27 "excess errors" failures. All of
them are
error: cast from 'int*' to 'int' loses precision
Using long works better than int, but is still not fool proof, as there
are targets where longs are smaller than pointers. Maybe we can rely on
something like ptrdiff_t?
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
