On Fri, Sep 08, 2023 at 02:58:40PM +0200, Arthur Cohen wrote:
> From: Raiki Tamura <tamaron1...@gmail.com>
>
> libcpp/ChangeLog:
>
> * charset.cc (check_xid_property):new function to check XID_Start and
> XID_Continue
> * include/cpplib.h (check_xid_property):add enum representing XID
> properties
Just random comments, not a proper review.
1) functions exported from libcpp should IMNSHO use the cpp_ prefix
2) similarly the enumerators should be prefixed with CPP_
3) formatting of the ChangeLog entry is incorrect. There should be a space
after ): followed by uppercase rather than lowercase letter, descriptions
should end with . and there should be line wrapping so that it fits into 80
columns. For a new function, one can just say New. or New function.,
doesn't need to describe what it is good for. And the include/cpplib.h
changes don't describe what actually changed. A new anonymous enum (why not
a named one?) was added, and check_xid_property declared.
> --- a/libcpp/include/cpplib.h
> +++ b/libcpp/include/cpplib.h
> @@ -1606,4 +1606,11 @@ bool cpp_valid_utf8_p (const char *data, size_t
> num_bytes);
> bool cpp_is_combining_char (cppchar_t c);
> bool cpp_is_printable_char (cppchar_t c);
>
> +enum {
> + XID_START = 1,
> + XID_CONTINUE = 2
Formatting. There should be indentation just by 2 columns rather than 3.
Jakub
--
Gcc-rust mailing list
Gcc-rust@gcc.gnu.org
https://gcc.gnu.org/mailman/listinfo/gcc-rust
