On 06/08/2021 16:55, cohenarthur.dev wrote: > On 21/08/06 03:31PM, Philip Herron wrote: >> On 04/08/2021 21:25, Mark Wielaard wrote: >>> Hi, >>> >>> On Wed, Aug 04, 2021 at 03:15:00PM +0000, build...@builder.wildebeest.org >>> wrote: >>>> The Buildbot has detected a new failure on builder gccrust-debian-arm64 >>>> while building gccrust. >>>> Full details are available at: >>>> https://builder.wildebeest.org/buildbot/#builders/58/builds/270 >>>> >>>> Buildbot URL: https://builder.wildebeest.org/buildbot/ >>>> >>>> Worker for this Build: debian-arm64 >>>> >>>> Build Reason: <unknown> >>>> Blamelist: CohenArthur <arthur.co...@epita.fr> >>>> >>>> BUILD FAILED: failed compile (failure) >>> This commit (and the following 3) were really bad. They didn't build. >>> Apparently bors doesn't check commit individually, but the buildbot >>> does build every commit separately. > Really sorry about this. > >>> The tree is buildable again, but I think it would be good to not have >>> any commits that break the build. >>> >>> Periodically broken trees make it also hard to bisect issues. >>> >>> Is it possible to make bors check all commits in a series? Or can we >>> somehow connect the buildbot workers to the bors checks? > I think bors is mostly focused on having the latest commit on the main > branch always build, but I might be wrong on this. I think it should be > possible to integrate buildbot to the CI on github directly, side to > side with bors. > >>> Thanks, >>> >>> Mark >>> >> Hi Mark, >> >> I think the build-bot checks for every commit is a really nice feature >> here. I think you should keep the build-bots as are. I really like to >> make sure each of my commits are build-able and pass tests. It keeps me >> honest to avoid regressions as best I can. >> >> What do you think? >> >> Thanks >> >> --Phil >> > I'm really sorry about not having all the commits build. I tried to keep > them as atomic as possible and clearly didn't check all of them > separately. This could have been a single commit and would have avoided > this, but since each change was big I decided to split them up. > > I was not aware that buildbot checks every commit separately. I think > this is a good feature, and I'll keep it in mind. Won't happen again! > > Sorry again, > > -- > Arthur
No need to apologies Arthur, you've done great work! This is something we haven't thought about before until now. Thanks --Phil
OpenPGP_signature
Description: OpenPGP digital signature
-- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
