Jeff Law <l...@redhat.com> writes:

> On 12/04/14 15:42, Rainer Orth wrote:
>> David Malcolm <dmalc...@redhat.com> writes:
>>
>>> <dejagnu.h> assumed -fgnu89-inline until a recent upstream fix;
>>> see http://lists.gnu.org/archive/html/dejagnu/2014-10/msg00011.html
>>>
>>> Remove the workaround from jit.exp that used -fgnu89-inline
>>> in favor of a fixincludes to dejagnu.h that applies the upstream fix
>>> to a local copy.
>>>
>>> This should make it easier to support C++ testcases from jit.exp.
>>
>> I wonder how this would work if dejagnu.h doesn't live in a system
>> include dir (e.g. a self-compiled version)?  fixincludes won't touch
>> those AFAIU.  The previous version with -fgnu89-inline would still work
>> in that case provided dejagnu.h is found at all.
> Presumably in that case the answer is upgrade dejagnu? :-)

I've two problems with this:

* There's not yet a DejaGnu release available with the fix and I've no
  idea if there are any planned any time soon.  Not everyone is
  comfortable with random git (or whatever) snapshots.

* I don't consider this a critical issue that cannot work without
  current releases.  We're already working around several upstream
  DejaGnu issues in our codebase, and I don't consider this particular
  one important enough to require everyone to upgrade to a not-a-release
  version.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to