On Thu, Nov 20, 2014 at 05:33:57PM -0600, James Norris wrote:
> >>+ t = OMP_CLAUSE_ASYNC_EXPR (c);
> >>+ if (t == error_mark_node)
> >>+ remove = true;
> >>+ else if (!type_dependent_expression_p (t)
> >>+ && !INTEGRAL_TYPE_P (TREE_TYPE (t)))
> >>+ {
> >>+ error ("%<async%> expression must be integral");
> >You have OMP_CLAUSE_LOCATION (c) which you could use for error_at.
>
> I followed the convention that was used elsewhere in the function
> at using error ().
Perhaps it would be better to change even those other spots in the function.
But that can be certainly done as a follow-up patch.
> Thank you for taking the time to review!
>
> OK to commit after middle end has been accepted?
Yes, thanks.
Jakub
