On Thu, Nov 20, 2014 at 05:50:33PM -0600, James Norris wrote:
> >>+ case 'h':
> >>+ if (!strcmp ("host", p))
> >>+ result = PRAGMA_OMP_CLAUSE_SELF;
> >>+ break;
> >Shouldn't this be PRAGMA_OMP_CLAUSE_HOST (PRAGMA_OACC_CLAUSE_HOST)
> >instead? It is _HOST in the C++ patch, are there no C tests with
> >that clause covering it?
>
> The "host" clause is a synonym for the "self" clause. The initial
> C++ patch did not treat "host" as a synonym and has amended
> accordingly.
Can you add a comment mentioning that (for casual readers)?
> There was a mistake in naming the function:
> c_parser_omp_clause_vector_length.
> Once it was renamed to: c_parser_oacc_clause_vector_length, diff was able to
> keep track.
Great.
> OK to commit after middle end is accepted?
Ok, thanks.
Jakub
