On Thu, Nov 13, 2014 at 11:11:41AM +0100, Marek Polacek wrote:
> On Thu, Nov 13, 2014 at 09:45:50AM +0100, Richard Biener wrote:
> > Hmm, I'd have expected to test !TYPE_OVERFLOW_SANITIZED (),
> > that is, have the predicate inverted.  At least that's how
> > I understand the name - an overflow is to be preserved for
> > sanitization.
>  
> I guess that macro name is a little bit baffling ;).
> 
> > So - can you invert the predicates (and uses)?  In the
> > sanitizer you then can guard instrumentations with
> > TYPE_OVERFLOW_SANITIZED.
>  
> Done.
> 
> > Ok with that change.
> 
> Thanks, this is the inverted version:
> 
> 2014-11-13  Marek Polacek  <pola...@redhat.com>
> 
>       * tree.h (TYPE_OVERFLOW_SANITIZED): Define.
>       * fold-const.c (fold_binary_loc): Use it.
>       * match.pd: Likewise.

That looks good.

        Jakub

Reply via email to