On Tue, Nov 11, 2014 at 01:54:08PM +0000, Julian Brown wrote:
> From 1f17beb70b5607d1884fad1cb4734857f0e7846f Mon Sep 17 00:00:00 2001
> From: Julian Brown <[email protected]>
> Date: Mon, 22 Sep 2014 02:45:29 -0700
> Subject: [PATCH 3/5] OpenACC documentation.
>
> xxxx-xx-xx Thomas Schwinge <[email protected]>
> James Norris <[email protected]>
>
> libgomp/
> * libgomp.texi: Outline documentation for OpenACC.
> ---
> libgomp/libgomp.texi | 661
> ++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 636 insertions(+), 25 deletions(-)
>
> diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi
> index 254be57..9530a2b 100644
> --- a/libgomp/libgomp.texi
> +++ b/libgomp/libgomp.texi
> @@ -31,10 +31,12 @@ texts being (a) (see below), and with the Back-Cover
> Texts being (b)
> @ifinfo
> @dircategory GNU Libraries
> @direntry
> -* libgomp: (libgomp). GNU OpenMP runtime library
> +* libgomp: (libgomp). GNU OpenACC and OpenMP runtime
> library
> @end direntry
See Dave Malcolm's patch, please integrate it into your patchset.
> -This manual documents the GNU implementation of the OpenMP API for
> +This manual documents the GNU implementation of the OpenACC API for
> +offloading of code to accelerator devices in C/C++ and Fortran and
> +the GNU implementation of the OpenMP API for
> multi-platform shared-memory parallel programming in C/C++ and Fortran.
I'd write:
"This manual documents the GNU implementation of the OpenMP API
for multi-platform shared-memory parallel programming in C/C++ and Fortran
and OpenACC and OpenMP API for offloading of code to accelerator devices
from the same languages."
or so.
> +The variables @env{ACC_DEVICE_TYPE} and @env{ACC_DEVICE_NUM}
> +are defined by section 4 of the OpenACC specification in version 2.0.
> +The variable @env{GCC_ACC_NOTIFY} is used for diagnostic purposes.
> +
> +@menu
> +* ACC_DEVICE_TYPE::
> +* ACC_DEVICE_NUM::
> +* GCC_ACC_NOTIFY::
If the env var name is adjusted to GACC_NOTIFY, GOACC_NOTIFY or even
GOMP_ACC_NOTIFY (as the library is libgomp), please don't forget to change
this spot too.
> +As the OpenACC library is built using the CUDA Driver API, the question has
Is it? I thought only the nvptx plugin is.
Otherwise LGTM.
Jakub
