On Wed, 2014-11-12 at 14:16 +0100, Tom de Vries wrote: I can't speak to the rest of the patch, but one readability nitpick:
> diff --git a/gcc/passes.def b/gcc/passes.def > index 2305d67..dd91718 100644 > --- a/gcc/passes.def > +++ b/gcc/passes.def > @@ -241,6 +241,9 @@ along with GCC; see the file COPYING3. If not see > POP_INSERT_PASSES () > NEXT_PASS (pass_iv_canon); > NEXT_PASS (pass_parallelize_loops); > + PUSH_INSERT_PASSES_WITHIN (pass_parallelize_loops) > + NEXT_PASS (pass_expand_omp_ssa); > + POP_INSERT_PASSES () Please can you add an indentation level within the PUSH/POP pair, giving something like this? + PUSH_INSERT_PASSES_WITHIN (pass_parallelize_loops) + NEXT_PASS (pass_expand_omp_ssa); + POP_INSERT_PASSES () (the rest of the file is using 4 spaces worth of indentation for each nesting level, tabifying multiples of 8) Thanks Dave
