On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison
<[email protected]> wrote:
>
> Patch that removes extraneous comment attached.
>
> The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For the
> vector intrinsic vclz this is incorrect and should return the value
vclz_{s,u}8 ...
> eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue.
The patch is ok . Sorry about the delay in reviewing this.
Ramana
>
> Tested on arm-linux-gnueabihf, arm-linux-gnueabi.
>
> 2014-10-08 Michael Collison <[email protected]>
>
> * config/arm/arm.h (CLZ_DEFINED_VALUE_AT_ZERO) : Update
> to support vector modes
> (CTZ_DEFINED_VALUE_AT_ZERO): Ditto
>
> On 10/09/2014 12:55 AM, Tejas Belagod wrote:
>>
>> On 09/10/14 08:05, Michael Collison wrote:
>>>
>>>
>>> The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the
>>> vector intrinsic vclz this is incorrect and should return the value
>>> eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue.
>>>
>>> Tested on arm-linux-gnueabihf, arm-linux-gnueabi.
>>>
>>> 2014-10-08 Michael Collison <[email protected]>
>>>
>>> * config/arm/arm.h (CLZ_DEFINED_VALUE_AT_ZERO) : Update
>>> to support vector modes
>>> (CTZ_DEFINED_VALUE_AT_ZERO): Ditto
>>>
>>
>> Update comment?
>>
>> /* The arm5 clz instruction returns 32. */
>>
>>
>> Thanks,
>> Tejas.
>>
>
> --
> Michael Collison
> Linaro Toolchain Working Group
> [email protected]
>
