RE: [Ping] [PATCH, 4/10] expand ccmp

[Zhenqiang Chen]

> -----Original Message-----
> From: Richard Henderson [mailto:r...@redhat.com]
> Sent: Thursday, October 30, 2014 11:58 PM
> To: Zhenqiang Chen
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Ping] [PATCH, 4/10] expand ccmp
> 
> On 10/29/2014 03:30 AM, Zhenqiang Chen wrote:
> > +
> > +bool
> > +ccmp_insn_p (rtx object)
> > +{
> > +  rtx x = PATTERN (object);
> > +  if (targetm.gen_ccmp_first
> > +      && GET_CODE (x) == SET
> > +      && GET_CODE (XEXP (x, 1)) == COMPARE
> > +      && (GET_CODE (XEXP (XEXP (x, 1), 0)) == IOR
> > +     || GET_CODE (XEXP (XEXP (x, 1), 0)) == AND))
> > +    return true;
> > +  return false;
> > +}
> > +
> 
> With the ifcvt changes I requested, I believe this is now unused.

Yes. No one uses ccmp_insn_p. Removed from ccmp.{h, c}.
 
> > +}
> > +rtx
> > +expand_ccmp_expr (gimple g)
> 
> Watch your spacing.  And you're missing the comment before the function.

Updated.

Thanks!
-Zhenqiang
 
> Otherwise ok.
> 
> 
> r~

3-4-ccmp.patch
Description: Binary data