Hi Julian! On Tue, 28 Oct 2014 13:19:18 +0000, Julian Brown <jul...@codesourcery.com> wrote: > This patch removes the goacc_parse_device_num function in libgomp's > env.c since it is redundant with parse_int. I also added some bounds > checking for the device number in oacc-init.c (the behaviour is left as > "implementation defined" in the OpenACC 2.0 spec, so I chose to raise > an error for an out-of-range device number).
I'd encourage to put such a comment into the source code, and/or into the manual. > OK for gomp4 branch? Yes, thanks! > libgomp/ > * env.c (goacc_parse_device_num): Remove. > (initialize_env): Use parse_int instead of goacc_parse_device_num. > * oacc-init.c (lazy_open): Add bounds check for device number. Grüße, Thomas
pgpzbjXDZ5YMP.pgp
Description: PGP signature
