On 18 October 2014 14:43, Anthony Brandon <anthony.bran...@gmail.com> wrote: > Never mind about functions.texi. I figured out how to do it. > Here is the new diff and changelog. > > libiberty/ChangeLog: > > 2014-10-18 Anthony Brandon <anthony.bran...@gmail.com> > > * filename_cmp.c (filename_eq): No change.
Unfortunately mklog is not 100% perfect (actually, it is 'diff -p' which is far from perfect). You need to revise that the ChageLog makes sense (or make mklog smarter). Thus, drop (filename_eq)... Also, the changelogs should say PR driver/36312 (https://gcc.gnu.org/codingconventions.html#ChangeLogs). I think you need to explain the difference between using fatal_error() and fatal_error(UNKNOWN_LOCATION). Yes, I should know because I wrote this part of the patch. But to be honest, I don't remember why I did this change. +This function first normalizes the file names so that different file names +pointing to the same underlying file are treated as being identical. I would suggest: "This function compares the canonical versions of the filenames as returned by @code{lrealpath()}, so that ..." I cannot approve the patch, but it looks fine to me. If you don't get a reply in a few days, you should ping the relevant maintainers: https://gcc.gnu.org/wiki/Community#ping Great first contribution! What are your plans next? Cheers, Manuel.
