On Thu, Oct 16, 2014 at 03:17:36PM +0400, Ilya Verbin wrote:
> On 15 Oct 16:38, Jakub Jelinek wrote:
> > > Done. But it turned out that the gcc_GAS_CHECK_FEATURE from
> > > gcc/configure.ac:
> > >
> > > gcc_GAS_CHECK_FEATURE([.section with e], gcc_cv_as_section_has_e,
> > > [2,22,51],,
> > > [.section foo1,"e"
> > > .byte 0,0,0,0])
> > >
> > > does not work properly. Maybe it works on "cygwin* | pe | mingw32* |
> > > interix*"
> > > targets, but on linux with GNU as version 2.20.51 (which doesn't support
> > > exclude
> > > sections) it successfully assembles conftest.s into conftest.o (with
> > > warnings)
> > > and HAVE_GAS_SECTION_EXCLUDE becomes defined.
> >
> > IMHO a version check is wrong (except when using in-tree gas).
> > I'd suggest just to use [--fatal-warnings] as the 4th argument to
> > gcc_GAS_CHECK_FEATURE feature, after all, that is what e.g.
> > gcc_cv_as_shf_merge testing already uses.
>
> Fixed. Patch is updated and retested.
Can you please extract the configure{,.ac}, langhooks.c and varasm.c
bits into a separate patch? That is preapproved for trunk right now, that
isn't dependent on anything else.
The rest LGTM, but please run it through LTO review (Richard/Honza) too.
Jakub
