Manuel López-Ibáñez <lopeziba...@gmail.com> writes:
> A few cleanups in line-map code. Bootstrapped and regression tested on
> x86_64-linux-gnu.
Thanks for doing this.
> OK?
Yes, barring this little nit:
[...]
> Index: libcpp/line-map.c
> ===================================================================
> --- libcpp/line-map.c (revision 216098)
> +++ libcpp/line-map.c (working copy)
> @@ -29,12 +29,10 @@ along with this program; see the file CO
> static void trace_include (const struct line_maps *, const struct line_map
> *);
> static const struct line_map * linemap_ordinary_map_lookup (struct line_maps
> *,
> source_location);
> static const struct line_map* linemap_macro_map_lookup (struct line_maps *,
> source_location);
> -static source_location linemap_macro_map_loc_to_def_point
> -(const struct line_map*, source_location);
This is not redundant per se, is it? It's just a forward declaration of
the function that is defined later. Just like for
linemap_macro_map_loc_unwind_toward_spelling() below. Or what am I
missing? I'd prefer to see this forward declaration stay, FWIW.
Otherwise, this cleanup patch looks good to me. If it was my call, I'd
say "OK with that change".
Thank you for tackling this.
--
Dodji
